Josee9988 / MinifyAll

A 𝗩𝗦𝗖𝗼𝗱𝗲 𝗺𝗢𝗻𝗢𝗳𝗢𝗲𝗿 for JS, JSON/C, CSS, and HTML, you will love its simplicity! 🌟 π˜Ύπ™€π™’π™₯π™§π™šπ™¨π™¨ and π™œπ™―π™žπ™₯ files and folders πŸ“¦ Reduce your bundle and file sizes with lightning speed ⚑
https://minifyall.jgracia.es/
GNU General Public License v3.0
72 stars 13 forks source link

Minify on Save - ONLY if a minified file already exists #145

Open minig0d opened 2 years ago

minig0d commented 2 years ago

πŸš€ Feature Request

Is your feature request related to a problem? Please describe.


Describe the solution you'd like


Describe alternatives you've considered

*


Additional context

*

welcome[bot] commented 2 years ago

Thanks for opening your first issue in Josee9988/project-template! Be sure to follow the issue template and provide every bit of information to help the developers!

Josee9988 commented 2 years ago

Hey, it definitely makes sense! I will love to add this feature. But this will have to wait as I am no longer maintaining this project as I am focusing on other projects and university.

But I will make it happen sooner or later.

I hope you understand!! πŸ™

Cube707 commented 2 years ago

Hello,

there is also the feature request under #131 which asks for an easy way to tell minify what files to just ignore. As both of these requests are quite similar in that the user wants to prevent some unnecessary files from being minified while not having to manually trigger the minifyer for worked on files, these could maybe be combined into a single feature.

Would the "define ignore patters" approach already suite your workflow?

Josee9988 commented 2 years ago

Yep #131 should fix this one

Josee9988 commented 2 years ago

I'll see if I can buy some free time and add this feature, at least.

minig0d commented 2 years ago

Hello,

there is also the feature request under #131 which asks for an easy way to tell minify what files to just ignore. As both of these requests are quite similar in that the user wants to prevent some unnecessary files from being minified while not having to manually trigger the minifyer for worked on files, these could maybe be combined into a single feature.

Would the "define ignore patters" approach already suite your workflow?

It would be better than nothing but no.... this is based on an assumption that 100% of the files I edit should have a minified version created... I edit TONS of different files for all different purposes. I would have to break into separate folder level settings because even at the workspace-level I don't minify everything. I only minify files I edit ad-hoc direct for web publishing...

Honestly, I if I was thinking about every file being minified, that would seem more like a better use of webpack, grunt, or gulp... In my opinion, the benefit for it is when doing ad-hoc editing... Ex. If I'm trying to make minor tweaks on a production website, making a tiny change, then making a second tiny change, then making a third... I have to re-minify between each time for the changes to go live.

I don't know... maybe if my workspaces were more organized.... but I tend to use a couple workspaces for everything.

I think as long as the setting worked correctly as a "folder" level-setting I could make it work because I could specifically create folder-level settings to enable it a a folder-level only in specific folders.... but I would never enable the feature globally as a workspace or user config. I just edit so many different types of files for so many reasons (ex. a snippet of css/js here and there that aren't part of formal projects). But in all of these cases, the same logic holds true... if there is a .min.js or .min.css file in the folder, I also want to update the minified version. 100% of the time. I could never say the same about a user/workspace/folder level setting.

And I've never tried to code anything that used user provided include/exclusionary patterns, but I'd imagine it's a heck of a lot less work to just do an async file exists test vs. interpreting globs or utilizing .ignore files etc. (I.e. selfishly my idea will probably take 30 minutes at most.... glob/ignore 5x that) :)

supersuphot commented 5 months ago

I move from Minify by HookyQR and I find this feature very useful. It only minifies if the *.min.ext file exists. I wish this feature could be implemented in other extensions as well.