Josee9988 / MinifyAll

A 𝗩𝗦𝗖𝗼𝗱𝗲 𝗺𝗢𝗻𝗢𝗳𝗢𝗲𝗿 for JS, JSON/C, CSS, and HTML, you will love its simplicity! 🌟 π˜Ύπ™€π™’π™₯π™§π™šπ™¨π™¨ and π™œπ™―π™žπ™₯ files and folders πŸ“¦ Reduce your bundle and file sizes with lightning speed ⚑
https://minifyall.jgracia.es/
GNU General Public License v3.0
73 stars 13 forks source link

Not working if code contains Optional Chaining Operator #65

Closed sankarkumar23 closed 4 years ago

sankarkumar23 commented 4 years ago

Looks like javascript's Optional Chaining Operator "?." has not been incorporated. Giving out error if code contains "?." Appreciate if this can be fixed ASAP.

Josee9988 commented 4 years ago

TL;DR

The JS minimization is done by an external package called terser which is out of my hands and it is not developed by me.


Hi, JavaScript minimization is done witj a 3rd party package, which it is not developed by me. The rest of the languages are fully made by me but not the JS one.

The terser's JS minimization is an extra feature for the extension MinifyAll, but not a part of the MinifyAll core.

This issue should be posted in the terser's issue page.

Thanks for contributing

sankarkumar23 commented 4 years ago

Thanks for the information.

Josee9988 commented 4 years ago

Anyways, I will update the terser package to obtain the latest features.

sankarkumar23 commented 4 years ago

After contacting terser this feature has been incorporated with v5.2.0. https://github.com/Josee9988/MinifyAll/blob/8a350fb1c45b981e1f41cf8bc3b0fb71dc3e2927/package.json#L263 Can I update to latest terser version in my local machine.. until you update your package. If yes, please explain how?

Josee9988 commented 4 years ago

I will try to publish a new version tomorrow.

If you need it now, go to the VSCode extension folder, search the MinifyAll folder, then open a terminal and write:

npm update terser

sankarkumar23 commented 4 years ago

Awesome.. If it can happen very soon.. I'll wait. Thank a lot for all your support.

Josee9988 commented 4 years ago

I'll comment again when the terser package is updatedm

Josee9988 commented 4 years ago

Update the MinifyAll extension to its latest version (2.4.7).

Terser was updated to 5.3.2.

sankarkumar23 commented 4 years ago

Update the MinifyAll extension to its latest version (2.4.7).

Terser was updated to 5.3.2.

Not sure If I am missing something.. after upgrade minify is completely failing.. it is generating a min file with no content.. just showing undefined.

Josee9988 commented 4 years ago

Please post a new issue with detailed information/media prove about this new issue.