search

Josee9988 / MinifyAll

A 𝗩𝗦𝗖𝗼𝗱𝗲 𝗺𝗢𝗻𝗢𝗳𝗢𝗲𝗿 for JS, JSON/C, CSS, and HTML, you will love its simplicity! 🌟 π˜Ύπ™€π™’π™₯π™§π™šπ™¨π™¨ and π™œπ™―π™žπ™₯ files and folders πŸ“¦ Reduce your bundle and file sizes with lightning speed ⚑
https://minifyall.jgracia.es/
GNU General Public License v3.0
73 stars 13 forks source link

Seems to create the file but somehow not really there #93

Open eddiepmonark opened 3 years ago

eddiepmonark commented 3 years ago

Installed and restarted vscode, pressed CTRL+ALT+N and it seems to create a new file leaving the original as well as expected. I even open the file from explorer or vscode sidebar and it's there.

BUT when I ALT+click on the link file from my html doc to go and open the new minified js file, I get this

Unable to open 'filenamer.min.js' Unable to read file '........... file location' (Error: Unable to resolve non-existing file '........... file location') [Create File] [Cancel]

Creating the file manually has no issues Tried JS & CSS Minifier (Minify) and worked right away.

Josee9988 commented 3 years ago

Is the file that you are creating with CTRL+ALT+N actually in your file system or is it a scratch file?

What minifyall command are you using?

May you send a video so I can see what the exact problem is?

Thanks!

eddiepmonark commented 3 years ago

It is being created since I see it on my folder and in vscode. After the shortcut, vscode opens the file, then I was trying to link to it (adding .min) and another time I tried to SAVE the file in case it wasn't saved. Same.

I believe I was clear on that and on the command I'm using.

Josee9988 commented 3 years ago

Well... a video could be helpful or if you could give more information.

So I would like to deeply analyze what the problem is. I surely don't know which of the 4 MinifyAll commands are you using and I would love to be 100% sure before I check anything.

All the tests are working in my machine and all the command seems to work ok, so I want to know exactly what doesn't work.

Josee9988 commented 3 years ago

Is the newly created file accessible through your file system and it is correctly minified?

Josee9988 commented 3 years ago

@eddiepmonark I have checked all the commands in Windows and Linux and I got no problem whatsoever, anyways, what you are telling me doesn't seem like a bug produced from the extension. But I really need more information to evaluate what may be going on.

Josee9988 commented 3 years ago

Could you try it again with the newest version (2.5.18) I've been really checking the deployment and what the causes might be, and I think I've fixed it, but I would like an extra confirmation of yours :)

eddiepmonark commented 3 years ago

I will give a try later today. Sorry got so much to clean up.

From: Jose Gracia Berenguer @.> Sent: 11 April 2021 04:50 To: Josee9988/MinifyAll @.> Cc: Eddie Potros @.>; Mention @.> Subject: Re: [Josee9988/MinifyAll] Seems to create the file but somehow not really there (#93)

Could you try it again with the newest version (2.5.18) I've been really checking the deployment and what the causes might be, and I think I've fixed it, but I would like an extra confirmation of yours :)

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Josee9988/MinifyAll/issues/93#issuecomment-817294620, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMYOEKVW2MW4SQ5AECN6S2TTIGEJBANCNFSM42TLRYQA.

Josee9988 commented 3 years ago

Ok don't worry, but please make sure to set the setting "MinifyAll.disableHexadecimalShortener" to its default value (true), because there is a bug with this option that might be the key of your problem

Josee9988 commented 3 years ago

Try to install the latest version "2.5.21" and check again. :)

Josee9988 commented 3 years ago

Hey, @eddiepmonark have you checked yet? You could check if the problem persists and then maybe changing your VSCode marketplace star to something more than 1 star. I think I gave my best to try to solve your issue.

The issue will be closed as it is mainly inactive and I think fixed as I had another issue that was probably related to your problem...

Cheers

Josee9988 commented 3 years ago

@eddiepmonark any news?

eddiepmonark commented 3 years ago

Sorry just been extremely busy with deadlines up till next week but I'll get to it for sure. Thanks

From: Jose Gracia Berenguer @.> Sent: 26 April 2021 07:53 To: Josee9988/MinifyAll @.> Cc: Eddie Potros @.>; Mention @.> Subject: Re: [Josee9988/MinifyAll] Seems to create the file but somehow not really there (#93)

@eddiepmonarkhttps://github.com/eddiepmonark any news?

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Josee9988/MinifyAll/issues/93#issuecomment-826899932, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMYOEKWYY7BYUPWWZQGQOJTTKV47BANCNFSM42TLRYQA.

eddiepmonark commented 3 years ago

https://user-images.githubusercontent.com/53535274/116287919-ce42d300-a745-11eb-865b-94aff77729e7.mp4

Same as before man.. I install the plugin and run it and it isn't working properly. I don't know what is the problem but the other plugin works as I showed you here.

eddiepmonark commented 3 years ago

One thing I don't understand is how it is the same file name as the other one yet, it doesn't overwrite or ask to do so. Smaller in file size and both are same timestamp after testing one after the other. As if your file isn't there or just working right.

Josee9988 commented 3 years ago

I'll check your evidence when I buy some time Ty