JosefCevik / JWManagement

GNU Affero General Public License v3.0
57 stars 30 forks source link

Added English (Australia) option to Framework Languages. #339

Closed apastorts closed 5 years ago

apastorts commented 5 years ago

Australian English has different date format, also in near future some expressions will be adapted too.

These features have been added:

  1. Description: In Australian English the date format is DD/MM/YYYY instead of MM/DD/YYYY also some expressions are different. I have created an en-AU language for English (Australia) where the date format is corrected and I will be adding new expressions to the translation. Tested by doing: In my local machine i can change the languages between English, German and English (Australian) and the date format changes properly.

Note: Please if I am wrong with the changes I am making let me know and I will change it as recommended.

Thank you very much for your hard work.

MarvinZeising commented 5 years ago

If you're okay with this, I would later go ahead and reduce the additions to just the lines that you actually need.

Awesome first pull request, btw! Thank you very much! :-)

apastorts commented 5 years ago

Hi @MarvinZeising,

Thank you!

It is my first project with meteor so I am sorry about the duplication i wasn't sure how it worked the i18n package, but I am here to learn and try to get some load from your shoulders. Please feel free to let me know any good advice or change I need to make, I am always happy to learn and improve as a programmer.

For your knowledge at the moment the only difference in the Australian translation is in the next files:

Those are the only files with changes in the dateFormat. I will be happy once the json is implemented to add more expressions some users have mentioned to me if it could be improve to avoid confusion.

I am more than happy to do this changes and commit them again, I wouldn't like to give you more work.

Thank you again.

MarvinZeising commented 5 years ago

I think you did a great job! Thanks for pointing out those three files. I'm just gonna merge this and migrate it to json. Shouldn't be too much effort. Then you can add the rest of the changes that the friends would be happy about :-)

Btw: when speaking about programming, do you want to do something more than translation? Like trying to solve one of the issues?

apastorts commented 5 years ago

@MarvinZeising

Yes sure!! I was just having a look at the program to understand it. And I decided to start with translation because some friends were commenting to me they were mixing up the dates.

Hehe and I thought: "Well good way to start learning".

But sure I am having a look to the issues and try to help in some of them.

muhkuhxy commented 5 years ago

Please feel free to ask as many questions as you like in the issues or on discord. Despite being German we do our best to be nice ;) I only started helping recently myself and I know it can be pretty overwhelming, especially if you don't have someone physically available to ask