search

JosefCevik / JWManagement

GNU Affero General Public License v3.0
57 stars 30 forks source link

Tweaks to English Language #393

Closed JasonRaveling closed 5 years ago

JasonRaveling commented 5 years ago

This pull request only includes changes to language files for English. Some of the grammar was a little odd. Possibly because of being translated from another language. The changes are minor but will hopefully help give some clarity to our English speaking friends. :-)

Since I'm not sure if the English option in settings is strictly for United States, I am leaving some things unchanged (e.g. referring to "Holiday" instead of "Vacation"). If the main English option is also used in Europe, I wouldn't want to mess things up for them. Maybe adding English (United States) as an option would be useful. Let me know.

JasonRaveling commented 5 years ago

Sounds good. Thank you. I was a bit cautious and skipped a few things since I wasn't sure where/how they were handled. I did notice in the email footer, it was showing an unescaped back slash (e.g. This is an automated mail. We don\'t expect an answer to it.) But if its being handled differently than other strings, I can see how it could be an issue. I'll take a look and see about adding the en-US option when I get a chance.