search

JosefCevik / JWManagement

GNU Affero General Public License v3.0
57 stars 30 forks source link

Implement translated privacy statement #440

Open tim-antkowiak opened 2 years ago

tim-antkowiak commented 2 years ago

The privacy statement is only available in German.

The text needs to be translated and and published (See terms links for reference).

In addition all links to the privacy statement needs to be adjusted to direct to the correct page, based on the browser language (already done for the terms links).

studiozandra commented 2 years ago

I would like to try solving this issue. I made a translation of the Privacy Policy to English, using machine translation. Also, I added a new FlowRouter route with privacyEN.

But, if I change my language setting to German in my JW Management profile, the 'Terms' link still points to en/terms. (In localstorage, the key changes from i18nextLng: en to de, but still Terms is in english.)

I even changed my browser language and OS language, but still get Terms in english. So it seems that href='/{{getLanguage}}/terms' in the footer template doesn't work.

Am I doing something wrong?

tim-antkowiak commented 2 years ago

Hey @studiozandra thanks for looking into this! If you open the console in the dev tools of your browser and execute 'navigator.language || navigator.userLanguage' what does it return? I think the result of that is what we are currently using for detecting the language here.

studiozandra commented 2 years ago

thanks kindly, that was helpful! I forgot to delete cookies and refresh. 👍👍

studiozandra commented 2 years ago

sorry, if my PR was confusing -- it's now deleted. I will fix branch and make a new PR.