JosefCevik / JWManagement

GNU Affero General Public License v3.0
57 stars 30 forks source link

440 translate privacy #453

Closed studiozandra closed 2 years ago

studiozandra commented 2 years ago

Feature added for issue #440:

  1. English Privacy Policy: machine translation via DeepL.com -- english has been proofread by me. Tested by changing browser language in Chrome on Linux : the correct URL matching the browser language is shown

Peek 2022-07-11optimized

gif made using https://github.com/phw/peek and https://ezgif.com/optimize

tim-antkowiak commented 2 years ago

Hey @studiozandra thank you so much for contributing!

We made some changes yesterday on the develop branch, sorry for the confusion.

To fix the commits you need to rebase your branch again on the current develop branch:

# Add the remote, call it "upstream":
git remote add upstream git@github.com:JWManagement/JWManagement.git

# Fetch all the branches of that remote into remote-tracking branches
git fetch upstream

# Make sure that you're on your branch:
git checkout 440-translate-privacy

# Rewrite your branch so that any commits of yours that
# aren't already in upstream/master are replayed on top of that
# other branch:
git rebase upstream/develop

# (Force) Push your branch
git push origin 440-translate-privacy --force

Could you try these steps?

studiozandra commented 2 years ago

Thank you very kindly! I have run those commands. Still a couple of other commits in there 🤔

tim-antkowiak commented 2 years ago

Yea, that were the commits we removed from the develop branch yesterday. I just updated your branch. Make sure to do a git fetch and maybe a git reset --hard origin/440-translate-privacy to get the updated branch on your local setup (don't forget to stash if you have local changes).