search

JosefCevik / JWManagement

GNU Affero General Public License v3.0
57 stars 30 forks source link

Allow user update via CSV import #478

Closed aloosen closed 1 year ago

aloosen commented 1 year ago

resolves #434

tim-antkowiak commented 1 year ago

Looks pretty smooth so far, nice work @aloosen !

I noticed one strange thing, not sure if it is only me.

If I click the "Add / Update Publishers" button the modal closes and the click handler is not called, so nothing happens.

If I remove the part (data-dismiss='modal') in updateUserFileModal.tpl.jade on line 54 the click handler is called and everything works fine, except the modal is not closed. I assume that the modal which contains the click handler is unloaded before the function is called.

But it should be the same on the current live version so not sure why it works there.

Maybe somebody else can test this?

tim-antkowiak commented 1 year ago

Nice work everyone!

I noticed one more thing: If in the csv file your own user is present I get an error on the console saying: "You are not allowed to revoke your own permissions. Another administrator has to do that.". And nothing is changed. Can we maybe put that in a alert or something if that happens to prevent confusion?