JosefNemec / Playnite

Video game library manager with support for wide range of 3rd party libraries and game emulation support, providing one unified interface for your games.
https://playnite.link
MIT License
9.15k stars 494 forks source link

install size not detected properly cxbx-reloaded #3741

Open ppvnf opened 4 months ago

ppvnf commented 4 months ago

Bug Description

the size of Virtua Cop 3, a Sega Chihiro game is not properly detected (the size of the executable is, but not the subfolder necessary to run the game, which is much larger)

To Reproduce

No response

Diagnostics ID

not needed

Screenshots

Screenshot_20240504_115644 Screenshot_20240504_120002

Jeshibu commented 4 months ago

I added a workaround for this to Games Size Calculator for PS3 ROMs but I can add Xbox ones too. I just want to get as many of these in one update as possible. Any other ROM types that typically are just folders full of files rather than a single file?

ppvnf commented 4 months ago

naomi/flycast as well

Screenshot_20240504_132000 Screenshot_20240504_132031 Screenshot_20240504_132044

Jeshibu commented 4 months ago

That's just one file which will get its size correctly counted by Playnite by default

ppvnf commented 4 months ago

but the chd is necessary to play the game as well. The zip is a different file

Epsilon99s commented 4 months ago

Probably not exactly on topic but can the size be calculated if the link to a rom file is in Actions tab in "Emulator Arguments" field instead of Installation tab? It's just one game might have tons of versions on different systems and you can't have those roms in Installation tab so you have to go with custom arguments for each emulator. Would be great to be able to calculate the size of them all. 2024-05-15_211647 2024-05-15_212751

Jeshibu commented 4 months ago

The solution to that would be picking the ROMs per emulator play action, not trying to guess which argument points to the ROM (with maybe a relative path).