search

JosefNemec / PlayniteExtensions

Extensions for Playnite game launcher and manager.
MIT License
174 stars 41 forks source link

Epic: Adding optional ubisoft import toggle #412

Closed Jhanlon95 closed 2 weeks ago

Jhanlon95 commented 1 month ago

Adds a check box in the library options defaulted to false. If selected it'll operate as it used to before the change to ignore them was implemented.

hawkeye116477 commented 1 month ago

If that will be added, then maybe useful would be also adding fix for tracking those games, which could be borrowed from https://github.com/JosefNemec/PlayniteExtensions/blob/d3b1b50f45aa174751852198172a28a5ae947c6d/source/Libraries/UplayLibrary/UplayGameController.cs#L146 and you can check if UplayLaunch.exe is available at game's install dir.

oscilloscopa commented 1 month ago

yeah that would be great

Jhanlon95 commented 1 month ago

I think it might be best to not overload this PR. I was only intending to allow the Ubisoft Imports to come back in again. If this PR is accepted then I will probably look into adding the tracking in as a separate PR. I do appreciate the pointer on where to look to implement it!

JosefNemec commented 2 weeks ago

I merged this into single commit together with EA change 0df49b63cc579f895399df4571f3a2941561576b

hawkeye116477 commented 2 weeks ago

In case of EA, people might still complain a little, cuz that will work only for newer games (older games are in other api).

JosefNemec commented 2 weeks ago

Not much we can do about that other than reworking how library data fetching works. Not sure how stuff like Legendary pulls info about those EA games.