nus-pe-bot
commented
6 months ago Team's Response
Thanks for catching this.
However, I think that It is quite uncommon for the situation where two people with the same name and different capitalisation is added to SweetRewards, and don't think it is medium severity.
Currently, there's no way to get around two members with the exact same name, but in our planned enhancements, we aim to solve this issue
- Add index-based selection for member selection: Currently in our addorder, addpts, addmempts, redeempts commands, we select the member based on the first member in the list whose name contains the entered string. This might prove as an issue when there are two people with the same or similar names like Wan Lei and Matthew Ang Wan Lei. If the latter is closer to the top of the list (added earlier), there will be no way to select Wan Lei. To prevent this, indexing selection for these commands should be added (E.g. addorder 3 i/Cookies would add the Cookies order to the third person in the current filtered list). This does not get rid of the current name selection, and merely introduces an alternative to member selection.
Items for the Tester to Verify
:question: Issue severity
Team chose [severity.Low]
Originally [severity.Medium]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
Command: addmem n/John Doe hp/98765432 e/johnd@example.com a/John street, block 123 addmem n/john doe hp/98765432 e/johnd@example.com a/John street, block 123 addpts n/john doe p/50
Actual: Added 50 point(s) to John Doe
Expected: Added 50 point(s) to john doe. The program should either disallow entries with the same name but difference cases or find a way to distinguish between the two of them.