Joseph31416 / pe

0 stars 0 forks source link

Additem command does not allow for item names with non alphanumeric characters #8

Open Joseph31416 opened 7 months ago

Joseph31416 commented 7 months ago

Command: additem i/kaya waffle (special) p/200

Actual: Item names should contain alphabets and spaces, and cannot be blank. additem: Adds an item to the catalogue. Parameters: i/ITEM_NAME p/POINTS_PER_UNIT Example: additem i/chocolate cake p/50

Expected: This item should be added as the user might want to have a special version of the item

bug 6.png

nus-se-script commented 6 months ago

Team's Response

Hi! Thanks for this! We are already planning to add this in our planned enhancements!

  1. Allow numbers and special characters in item names: Currently, item names only accept alphabetical characters. This prevents use cases such as items with quantities or special characters (E.g. Chocolate-Chip Cookies 100g) from being entered. We should allow alphanumeric and special characters.

    Items for the Tester to Verify

    :question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Thanks for responding. However, according to the course website, a severity low bug is one "that is unlikely to affect normal operations of the product [and ] appears only in very rare situations and causes a minor inconvenience only." (screenshot 1). I would say that this issue does not just occur in very rare situations as there could be a variety of reason for why the user might want to have special characters in the item name (as mentioned in the planned enhancement). Furthermore, this causes more than minor inconvenience as there would be no alternative to accomplishing the task of having item names with special characters. As such, I would classify this as a flaw that causes occasional inconvenience to some users, but they can continue to use the product, hence a severity of medium. Screenshot 1 ![Screenshot 2024-04-23 at 12.33.09 PM.png](https://raw.githubusercontent.com/Joseph31416/pe/main/files/9474df52-db8d-4265-8d69-3c90d5100e0d.png)