JosephDavidTalbot / Wordle-Clone

A clone of Wordle, with React/Typescript as the front-end and Python as the back-end.
0 stars 0 forks source link

Refactor tests to use pytest #6

Open tgittos opened 2 years ago

tgittos commented 2 years ago

You didn't use pytest, and you definitely didn't do any reading about how to properly test a Flask application. Refactor your test lib to properly leverage pytest and set up a proper test of the Flask application. You'll need to use a fixture to create a test client to test against at the very least.

As requested in the previous issue, please tag these issues in your commits, and work in a branch and submit PRs.

JosephDavidTalbot commented 2 years ago

I've given up on Storybook for the time being- I tried building a new component using it but for some reason the interface stopped recognizing that the new component existed- and so, instead, since I got a response from an interview that's asking me to do a technical assessment, I figured I might as well redo my first Flask server, and do the tests properly.

Any reading material on pytest and Flask integration that you can recommend, so I don't embarrass myself this time?

tgittos commented 2 years ago

This looks like a good place to start:

https://testdriven.io/blog/flask-pytest/

Great job on getting a tech screen, and good luck! Let me know if you want to practice interviewing tomorrow.

On Fri, Feb 18, 2022 at 2:01 PM Joseph Talbot @.***> wrote:

I've given up on Storybook for the time being- I tried building a new component using it but for some reason the interface stopped recognizing that the new component existed- and so, instead, since I got a response from an interview that's asking me to do a technical assessment, I figured I might as well redo my first Flask server, and do the tests properly.

Any reading material on pytest and Flask integration that you can recommend, so I don't embarrass myself this time?

— Reply to this email directly, view it on GitHub https://github.com/JosephDavidTalbot/Wordle-Clone/issues/6#issuecomment-1045107329, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAATKHSQ5I3ZM7BHGQK5ALU32QSBANCNFSM5OCEMP3Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

JosephDavidTalbot commented 2 years ago

...And the assessment turns out to be in Ruby, which I've never used before.

Lord have mercy.

tgittos commented 2 years ago

It's fine.

Ruby and Python are fairly close.

I find Ruby to be easier to reason about the language if you don't know much about it than any other language.

Start here: https://www.ruby-lang.org/en/documentation/ruby-from-other-languages/to-ruby-from-python/ Then run through this: https://guides.rubyonrails.org/getting_started.html

That should get you 80% of the way there, but also tell them you don't know Ruby and that you usually use Python.

On Fri, Feb 18, 2022 at 2:52 PM Joseph Talbot @.***> wrote:

...And the assessment turns out to be in Ruby, which I've never used before.

Lord have mercy.

— Reply to this email directly, view it on GitHub https://github.com/JosephDavidTalbot/Wordle-Clone/issues/6#issuecomment-1045170088, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAATKD3ZZK7YD7YJMIZY6LU32WQ7ANCNFSM5OCEMP3Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

JosephDavidTalbot commented 2 years ago

Yeah, I'm sure I'll figure it out just fine- one of the things that was taught pretty well at ACC was learning new programming languages. It's just that the last time I wrote a RESTful API endpoint for a Hatchways-mediated technical assessment using a framework that was completely new to me, I didn't get any further in the interview process.

tgittos commented 2 years ago

Thats ok. These interviews are practice runs, really. Just do your best, learn how to interview (it's definitely a skill).

Your Github is getting better but we still need to keep going with the Python/React stuff. You're learning a lot of great new things, and if you keep interviewing and practicing, you should be able to get a job no problem in a month or so.

On Fri, Feb 18, 2022 at 3:18 PM Joseph Talbot @.***> wrote:

Yeah, I'm sure I'll figure it out just fine- one of the things that was taught pretty well at ACC was learning new programming languages. It's just that the last time I wrote a RESTful API endpoint for a Hatchways-mediated technical assessment using a framework that was completely new to me, I didn't get any further in the interview process.

— Reply to this email directly, view it on GitHub https://github.com/JosephDavidTalbot/Wordle-Clone/issues/6#issuecomment-1045202694, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAATKA7VGNATWUJJ2URPRDU32ZSTANCNFSM5OCEMP3Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>