search

JosephEoff / MuseScore_UltraStar_Exporter

MuseScore plugin to create UltraStar files
GNU General Public License v2.0
0 stars 3 forks source link

High accuracy mode #10

Closed jeetee closed 8 years ago

jeetee commented 8 years ago

implements and closes #9 High-Accuracy Mode

Verified that with the checkbox disabled, results remain the same as before. High Accuracy exported file tested on Performous1.0 on Win7 successfully.

I've tried generating new translation files for these sources, to have it include this new string. It mostly works, but my version of Linguist generates ts version 2.1 files instead of the existing 2.0. This means that all line numbers for example are relative instead of absolute, resulting in a file with more changes than required.

Which of the following would you like best?

  1. I can add the one extra string manually into the ts files (quick and dirty)
  2. Just put up the files as generated by the new version and add them into this PR
  3. Open up a different PR with language file update (in this case, I'd also like to make the version number in the 'required version'-string a variable instead of translatable text)
JosephEoff commented 8 years ago

Go ahead and put up the files generated by the new Linguist. I'll have a look if they work with my older version. If that doesn't work we can revert the change and I'll put the new text into the translation file and commit it.

jeetee commented 8 years ago

There you go, now that I've touched Linguist briefly, I think adding a Dutch file in a different Pull request is likely to happen somewhere next week.

JosephEoff commented 8 years ago

Looks good. High accuracy exports, and performous can play it. Normal mode OK, too.