JosephLai241 / URS

Universal Reddit Scraper - A comprehensive Reddit scraping/archival command-line tool.
https://josephlai241.github.io/URS/
MIT License
801 stars 108 forks source link

Suggest to loosen the dependency on halo #56

Open Agnes-U opened 1 year ago

Agnes-U commented 1 year ago

Dear developers,

Your project URS requires "halo==0.0.31" in its dependency. After analyzing the source code, we found that the following versions of halo can also be suitable without affecting your project, i.e., halo 0.0.30. Therefore, we suggest to loosen the dependency on halo from "halo==0.0.31" to "halo>=0.0.30,<=0.0.31" to avoid any possible conflict for importing more packages or for downstream projects that may use ddos_script.

May I pull a request to further loosen the dependency on halo?

By the way, could you please tell us whether such dependency analysis may be potentially helpful for maintaining dependencies easier during your development?



Details:

Your project (commit id: 9f8cf3a3adb9aa5079dfc7bfd7832b53358ee40f) directly uses 6 APIs from package halo.

halo.halo.Halo.start, halo.halo.Halo.succeed, halo.halo.Halo.info, halo.halo.Halo.warn, halo.halo.Halo.fail, halo.halo.Halo.__init__

Beginning fromwhich, 28 functions are then indirectly called, including 17 halo's internal APIs and 11 outsider APIs as follows:

[/JosephLai241/URS]
+--halo.halo.Halo.start
|      +--halo.halo.Halo._check_stream
|      +--halo.halo.Halo._hide_cursor
|      |      +--halo.halo.Halo._check_stream
|      |      +--halo.cursor.hide
|      |      |      +--halo.cursor._CursorInfo.__init__
|      |      |      +--ctypes.windll.kernel32.GetStdHandle
|      |      |      +--ctypes.windll.kernel32.GetConsoleCursorInfo
|      |      |      +--ctypes.windll.kernel32.SetConsoleCursorInfo
|      |      |      +--ctypes.byref
|      +--threading.Event
|      +--threading.Thread
|      +--halo.halo.Halo._render_frame
|      |      +--halo.halo.Halo.clear
|      |      |      +--halo.halo.Halo._write
|      |      |      |      +--halo.halo.Halo._check_stream
|      |      +--halo.halo.Halo.frame
|      |      |      +--halo._utils.colored_frame
|      |      |      |      +--termcolor.colored
|      |      |      +--halo.halo.Halo.text_frame
|      |      |      |      +--halo._utils.colored_frame
|      |      +--halo.halo.Halo._write
|      |      +--halo._utils.encode_utf_8_text
|      |      |      +--codecs.encode
+--halo.halo.Halo.succeed
|      +--halo.halo.Halo.stop_and_persist
|      |      +--halo._utils.decode_utf_8_text
|      |      |      +--codecs.decode
|      |      +--halo._utils.colored_frame
|      |      +--halo.halo.Halo.stop
|      |      |      +--halo.halo.Halo.clear
|      |      |      +--halo.halo.Halo._show_cursor
|      |      |      |      +--halo.halo.Halo._check_stream
|      |      |      |      +--halo.cursor.show
|      |      |      |      |      +--halo.cursor._CursorInfo.__init__
|      |      |      |      |      +--ctypes.windll.kernel32.GetStdHandle
|      |      |      |      |      +--ctypes.windll.kernel32.GetConsoleCursorInfo
|      |      |      |      |      +--ctypes.windll.kernel32.SetConsoleCursorInfo
|      |      |      |      |      +--ctypes.byref
|      |      +--halo.halo.Halo._write
|      |      +--halo._utils.encode_utf_8_text
+--halo.halo.Halo.info
|      +--halo.halo.Halo.stop_and_persist
+--halo.halo.Halo.warn
|      +--halo.halo.Halo.stop_and_persist
+--halo.halo.Halo.fail
|      +--halo.halo.Halo.stop_and_persist
+--halo.halo.Halo.__init__
|      +--halo._utils.get_environment
|      |      +--IPython.get_ipython
|      +--halo.halo.Halo.stop
|      +--IPython.get_ipython
|      +--atexit.register

Since all these functions have not been changed between any version for package "halo" from [0.0.30] and 0.0.31. Therefore, we believe it is safe to loosen the corresponding dependency.