search

JosephLenton / PHP-Error

Better error reporting for PHP, and prettier too!
1.35k stars 151 forks source link

private method identifyTypeHTML() #7

Closed Geczy closed 12 years ago

Geczy commented 12 years ago

Changing it to public makes everything work again

[02-Jul-2012 15:46:29 UTC] PHP Fatal error:  Call to private method php_error\ErrorHandler::identifyTypeHTML() from context '' in C:\wamp\php\php_error.php on line 2123

[02-Jul-2012 15:46:29 UTC] PHP Stack trace:

[02-Jul-2012 15:46:29 UTC] PHP   1. php_error\{closure}() C:\wamp\php\php_error.php:0

[02-Jul-2012 15:46:29 UTC] PHP   2. php_error\ErrorHandler->reportException() C:\wamp\php\php_error.php:2274

[02-Jul-2012 15:46:29 UTC] PHP   3. php_error\ErrorHandler->reportError() C:\wamp\php\php_error.php:2048

[02-Jul-2012 15:46:29 UTC] PHP   4. php_error\ErrorHandler->generateDumpHTML() C:\wamp\php\php_error.php:2100

[02-Jul-2012 15:46:29 UTC] PHP   5. php_error\{closure}() C:\wamp\php\php_error.php:2134

[02-Jul-2012 15:46:29 UTC] PHP   6. php_error\{closure}() C:\wamp\php\php_error.php:0

[02-Jul-2012 15:46:29 UTC] PHP   7. php_error\ErrorHandler->__onShutdown() C:\wamp\php\php_error.php:2378

[02-Jul-2012 15:46:29 UTC] PHP   8. php_error\ErrorHandler->reportError() C:\wamp\php\php_error.php:1201

[02-Jul-2012 15:46:29 UTC] PHP   9. php_error\ErrorHandler->generateDumpHTML() C:\wamp\php\php_error.php:2100

[02-Jul-2012 15:46:29 UTC] PHP  10. php_error\{closure}() C:\wamp\php\php_error.php:2134
JosephLenton commented 12 years ago

Ok, got that in, I've made it public.

Error didn't occur for me, I think it's because I'm on PHP 5.4, and the closures have been improved.

Geczy commented 12 years ago

Make sure when you commit that you include the issue # in the commit message for reference. Cheers

Eg:

Closes #7, private method

JosephLenton commented 12 years ago

Good point.

Geczy commented 12 years ago

Seven closed issues and no way to reference them :(