JosephMajaseSithole / datejs

Automatically exported from code.google.com/p/datejs
0 stars 0 forks source link

0:00am == 0:00pm #26

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
var d1 = Date.parse("0:00am");
var d2 = Date.parse("0:00pm");
if(d1.getTime() == d2.getTime()) {
  alert("This shouldn't be");
}

What is the expected output? What do you see instead?
Either:
 * 0:00pm and 0:00am are rejected, or
 * 0:00am == 12:00am and 0:00pm == 12:00pm.

What version of the product are you using? On what operating system?
Using date-en-AU.js from SVN (r130) in Firefox 2.0.0.11 on Mac OS X 10.5.1

Please provide any additional information below.
I'm happy to be corrected on what 0:00am and 0:00pm mean, but it struck me as 
odd that these 
times were accepted.

Original issue reported on code.google.com by craig.e.anderson on 24 Jan 2008 at 6:07

GoogleCodeExporter commented 8 years ago
Oops. Was using a different version of the code. Please ignore and close. 
0:00pm == 12:00am.

Original comment by craig.e.anderson on 24 Jan 2008 at 7:15

GoogleCodeExporter commented 8 years ago
The Parser does do some "interpretation". It tries to figure out the most 
logical
result for the input string. Since "0:00 pm" does not exist, the Parser 
interprets
that you must of meant "0:00 am". 

At the moment "0:00 am" == "0:00 pm" and "13:00 am" == "13:00 pm". 

That kind of logic is certainly not ideal for some circumstances, and with the 
next
version of the library we should have more options in place to reject these 
kind of
results (if required).

Hope this helps. 

Original comment by geoff%co...@gtempaccount.com on 25 Jan 2008 at 4:17

GoogleCodeExporter commented 8 years ago

Original comment by geoff%co...@gtempaccount.com on 28 Feb 2008 at 5:30

GoogleCodeExporter commented 8 years ago
00:00 still outputs as 12pm instead of 12am.  I've also added a little logic so 
that it recognizes noon and midnight, noon properly outputs 12pm but midnight 
outputs 0am. I've attached the version of the script I'm using in case my 
adding those verbose times threw something off for me or even if there is a new 
version of the script. 

Original comment by ShoeMake...@gmail.com on 24 Sep 2014 at 2:09

Attachments: