JosephMart / loki-gm

Basic fun little project to make a GroupMe bot called Loki
https://loki-bot.now.sh
0 stars 0 forks source link

Have BOT_ID depend on environment #12

Closed JosephMart closed 4 years ago

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/josephmart/loki-bot/58bdu70lc ✅ Preview: https://loki-bot-git-jmm-different-deploy-envs.josephmart.now.sh

codecov-io commented 4 years ago

Codecov Report

Merging #12 into master will decrease coverage by 5.14%. The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   63.63%   58.49%   -5.15%     
==========================================
  Files           4        5       +1     
  Lines          44       53       +9     
==========================================
+ Hits           28       31       +3     
- Misses         16       22       +6     
Impacted Files Coverage Δ
src/services/EnvConfigService.ts 33.33% <33.33%> (ø)
src/services/GroupMeService.ts 26.66% <33.33%> (+1.66%) :arrow_up:
src/handlers/HeyHandler.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a1a929...50bb849. Read the comment docs.

JosephMart commented 4 years ago

Zeit now has preview and prod env variables so a lot of this work can be abstracted to use that instead :)