search

JosephMart / loki-gm

Basic fun little project to make a GroupMe bot called Loki
https://loki-bot.now.sh
0 stars 0 forks source link

Messaging service #8

Closed tristan957 closed 4 years ago

tristan957 commented 4 years ago

Abstract GroupMeSevice further into an impl of MessagingService in preparation for a potential re-org of the code.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/josephmart/loki-bot/690f7mdo9 ✅ Preview: https://loki-bot-git-messaging-service.josephmart.now.sh

codecov-io commented 4 years ago

Codecov Report

Merging #8 into master will increase coverage by 13.44%. The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #8       +/-   ##
===========================================
+ Coverage   63.63%   77.08%   +13.44%     
===========================================
  Files           4        5        +1     
  Lines          44       48        +4     
===========================================
+ Hits           28       37        +9     
+ Misses         16       11        -5
Impacted Files Coverage Δ
src/services/GroupMeService.ts 33.33% <40.00%> (+8.33%) :arrow_up:
src/handlers/HeyHandler.ts 72.72% <62.50%> (-27.28%) :arrow_down:
src/handlers/Handler.ts 100.00% <100.00%> (ø)
src/handlers/RootHandler.ts 100.00% <100.00%> (ø)
src/mocks/GroupMeServiceMock.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a1a929...89a2b6a. Read the comment docs.

tristan957 commented 4 years ago

10 should be merged into this PR before merging to master.