search

JosephSilber / page-cache

Caches responses as static files on disk for lightning fast page loads.
MIT License
1.21k stars 118 forks source link

Urldecode to filename #92

Open ideea opened 2 years ago

ideea commented 2 years ago

In case, when url contains utf8 symbols, Nginx cache won't work, cause files will be saved with encoded name.

ugido commented 2 years ago

This is only one part of the solution. The other part is to adjust the path and filename in method cache (or better in getDirectoryAndFileNames) in src/Cache Class.

https://github.com/JosephSilber/page-cache/issues/79#issuecomment-868945107

To test it, use a path containing special characters like german letters äöü...

ideea commented 2 years ago

yes, you are right, thanks.

ideea commented 2 years ago

@JosephSilber ping? :)

alignwebs commented 2 years ago

@JosephSilber is this repo still active or should we fork it?

JosephSilber commented 2 years ago

is this repo still active

Yes.

I work on open source in my free time. Unless there are truly show-stopping bugs, I don't generally review issues/PRs every day. I work on my open source projects in chunks of time, whenever I have the time available.

The next opportunity I have to dedicate a chunk of time to this project (hopefully later this week), I'll review this PR.

JosephSilber commented 1 year ago

hopefully later this week

:rofl:

Anyhow, how do you handle this in the Apache/nginx configuration?