search

JosephusPaye / Keen-UI

A lightweight Vue.js UI library with a simple API, inspired by Google's Material Design.
https://josephuspaye.github.io/Keen-UI/
MIT License
4.1k stars 438 forks source link

Allow for checking out (but not pushing) `CRLF` on Windows #503

Closed Lewiscowles1986 closed 2 years ago

Lewiscowles1986 commented 4 years ago

Git on windows defaults to CRLF when checking out and then converting to LF when push upstream.

This should allow linux and mac users to continue to follow LF, but allow pass on windows hosts with CRLF

Fixes #502

Lewiscowles1986 commented 3 years ago

Fixed conflicts after getting a second notification this was approved. Maybe it can merge now?

JosephusPaye commented 2 years ago

Thanks!

JosephusPaye commented 2 years ago

Found another approach, since this one has an error if you checkout LF on Windows, which is what I do.

Released in v1.3.2

Lewiscowles1986 commented 2 years ago

I'd forgotten all about this, but can you let me know a little more about the error?

JosephusPaye commented 2 years ago

The config below causes eslint to complain when line endings are not CRLF on Windows. Since I've setup Git to check with LF, and I edit with LF, I get lint errors with yarn lint.

'linebreak-style': [2, "windows"],