search

JosephusPaye / Keen-UI

A lightweight Vue.js UI library with a simple API, inspired by Google's Material Design.
https://josephuspaye.github.io/Keen-UI/
MIT License
4.1k stars 437 forks source link

Dart Sass deprecation warnings #528

Closed desko27 closed 1 year ago

desko27 commented 3 years ago

We just migrated from node-sass (which is deprecated) to the recommended sass package and encountered we cannot fix these warnings in our Vue project as they originate from keen-ui components.

This is just an example but there are lots of them:

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(strip-unit($value), strip-unit($base))

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
57 │         $value: strip-unit($value) / strip-unit($base) * 1rem;
   │                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    node_modules/keen-ui/src/styles/util.scss 57:17       to-rem()
    node_modules/keen-ui/src/styles/util.scss 31:17       rem()
    node_modules/keen-ui/src/styles/variables.scss 33:39  @import
    node_modules/keen-ui/src/styles/imports.scss 2:9      @import
    stdin 155:9                                           root stylesheet
JosephusPaye commented 3 years ago

Interesting. I'd be happy to merge a PR that fixes the warnings.