Keep the default bold weight in a variable

JosephusPaye / Keen-UI

A lightweight Vue.js UI library with a simple API, inspired by Google's Material Design.

https://josephuspaye.github.io/Keen-UI/

MIT License

4.1k stars 438 forks source link

Keep the default bold weight in a variable #541

Closed kilobyte2007 closed 2 years ago

kilobyte2007 commented 2 years ago

In some projects, we have different font sets and sometimes they don't include the 600 font-weight. By making this change we make it flexible to configure this using a global SASS variable.

JosephusPaye commented 2 years ago

Looks good 👍. We can merge after #538 is in.

JosephusPaye commented 2 years ago

I couldn't clone your branch to test this, it appears the branch was deleted on your fork? This is giving me a 404 https://github.com/kilobyte2007/Keen-UI/tree/bold-as-variable

kilobyte2007 commented 2 years ago

Sorry, I messed up and created the fork again. The branch should be available now!

kilobyte2007 commented 2 years ago

I have implemented the change here - https://github.com/JosephusPaye/Keen-UI/pull/547 Please take a look.