kilobyte2007
commented
2 years ago Hey, fixed the issues and commented on one of them which was intended.
Closed kilobyte2007 closed 1 year ago
kilobyte2007
commented
2 years ago Hey, fixed the issues and commented on one of them which was intended.
kilobyte2007
commented
2 years ago Hey @JosephusPaye any update here?
JosephusPaye
commented
2 years ago Hi @kilobyte2007 I'll have a look at this an the other PRs soon. Just very busy right now.
JosephusPaye
commented
2 years ago Looks good 👍. Could you please add an example that uses the #icon slot? That way we have something that tests it.
kilobyte2007
commented
2 years ago Actually, 2 of the examples are already using the icon slot (as it was done previously) so we already have something that tests it.
JosephusPaye
commented
2 years ago Sorry for the confusion if I'm missing something, but I can you point me to which examples use the icon slot? From what I can see they all use the icon prop on UiTab except for the custom header one which uses the header slot to render a UiIcon and the tab title.
kilobyte2007
commented
2 years ago I was referring to the first example:
JosephusPaye
commented
1 year ago Looks like something weird is happening. I can see on your branch the example with the icon template, but on this PR for some reason it's not the same.
Anyway this PR looks good. I'll go ahead and merge it now. Thanks for your patience!
The reason for this is that in Vue 3 we are required to use for slots and it creates a lot of boilerplate code for the UiTab component when it can be easily achieved with a simple icon prop. Let me know what you think!