search

JosephusPaye / Keen-UI

A lightweight Vue.js UI library with a simple API, inspired by Google's Material Design.
https://josephuspaye.github.io/Keen-UI/
MIT License
4.1k stars 438 forks source link

Build with vite (and rollup) #549

Closed kilobyte2007 closed 1 year ago

kilobyte2007 commented 2 years ago

I tried to experiment a little with building with vite so we can get rid of webpack. There was a bit of complication with the lib build as vite does not allow multiple entries but I have found an elegant way of doing it.

Please take a look once you have some time and let me know what you think.

JosephusPaye commented 2 years ago

Thanks for this! I'll have a closer look soon.

kilobyte2007 commented 1 year ago

Hey, @JosephusPaye any updates on this and the other PR and release of the new version?

Don't want to be rude or ungrateful but are there any plans to maintain and move the project forward? If the project will remain dormant maybe there is a sense for us to fork it and maintain a fork where we can implement new stuff and improve it.

JosephusPaye commented 1 year ago

Hi @kilobyte2007,

I'd definitely like the project to move forward as I still use it myself in production applications. I'd love to review the PRs you submitted and have been unsuccessfully trying to find time to do so in the last few weeks. I'm happy to give you commit access to the repo, and make you a maintainer, so I'm no longer a blocker. Let me know if that's something you're interested in.

Thanks!

kilobyte2007 commented 1 year ago

Hey @JosephusPaye, Thanks for reviewing this, I did not think to take a look at file sizes. Good catch. I'll take a look!

kilobyte2007 commented 1 year ago

Hey, I've updated the PR, all 4 issues are fixed now:

  1. I have configured rollup to exclude vue from the build and use the global Vue
  2. Now both minified and non-minified versions are being built when in production mode
  3. Fixed the banner, turns out we have to specify the outDir to the plugin as well
  4. There was indeed an issue as vite/rollup was cleaning the directory at random times

I've run some tests and it seems to work fine, but please let me know if you find any issues!

P.S. On making me a maintainer - I would be happy to join forces. Let me know what's going to be needed from me in this case and also what the workflow is going to look like from your perspective.

kilobyte2007 commented 1 year ago

Oh, totally forgot to migrate the HTML file from the previous version. I've brought it to the previous format now, please take a look!