Josh-Voyles / affordable

Affordible is a simple financial calculator that helps you determine what you can afford.
GNU General Public License v3.0
0 stars 0 forks source link

Pmi popup #120

Closed Josh-Voyles closed 2 months ago

YouKnowJoey commented 2 months ago

@randy-shreeves We could modify our current QMessageBox function to allow for specific text in the message, versus a fixed 'Error!' message

Josh-Voyles commented 2 months ago

The popup window doesn't occur after subsequent calculations or resets. It only populates after the first calculation.

I think a popup should occur if the user sets their PMI to 0% and their down payment is less than 20%, informing them that down payments < 20% typially require PMI.

Also if they set their PMI to >0% but their down payment is >= 20%, a pop up should inform them that typically no PMI is required with down payments greater than 20%.

The idea of a notification for downpayments great then 20 percent with PMI is a good idea. However, I think it can be an add-on to this current implimentation. Let's create an separate isssue as an enhancement.

Since PMI is already zero, I think it's more likely a user will ommit PMI when it's needed.

As for notifying only once, there are a couple challenges in implimentation.

I had a model working with text and a check box where the user could select the check box to discontinue receiving pop ups. However, the additional code added a lot of complexity and there there issues with formatting. Creating a separate class our building the QMessageBox in Qt Designer could be a future solution.

I suspect the user only needs to be notified one time to bring it to his/her attention. After that, the pop up auto-dismesses to prevent it annoyingly popping up everytime and creating friction. This is a middle ground for those who should have it and those who don't.

Future implementation can set the pop up to not occur if VA loan is selected or something like that.

Josh-Voyles commented 2 months ago

@randy-shreeves We could modify our current QMessageBox function to allow for specific text in the message, versus a fixed 'Error!' message

The QMessageBox box allows for loading a custom message which is already implimented.

Are you suggestion it be changed in some other way?