Normal collection test no longer fails randomly due to no-guarantee orde...

JoshAshby / pyRethinkORM

Basic, probably horribly written ORM style thing for RethinkDB in Python

https://rethinkorm.readthedocs.org/en/latest/

GNU General Public License v3.0

17 stars 9 forks source link

Normal collection test no longer fails randomly due to no-guarantee orde... #4

Closed grieve closed 10 years ago

grieve commented 10 years ago

RethinkDB does not guarantee ordering without using an order_by statement. So using straight comparison of lists to verify collection functionality fails inconsistently. Changed this to simply verify the existence of each record in the results. This merely compares IDs as these should be unique and property/field comparison should be covered in model tests.

JoshAshby commented 10 years ago

Looks good. Good catch, I'm slightly surprised this hasn't bit me in the rear yet.