search

JoshBarr / on-media-query

A neat way to trigger JS when media queries change. No jQuery required.
283 stars 33 forks source link

Fixed Demo Issues #15

Closed patocallaghan closed 11 years ago

patocallaghan commented 11 years ago

Changed demo to use 'match' signature

mhulse commented 11 years ago

We should merge this. Pat, don't you have the ability to merge this in?

mhulse commented 11 years ago

This is where I've got no experience. Stupid question: If we merge this fix, will #16 need to update their pull request with your changes before we merge their patch? I'd hate for your work to get stomped (or vice versa).

mhulse commented 11 years ago

I've looked over your changes and I feel like we can pull in this stuff no problems. If I don't hear from anyone by tomorrow, I'll go ahead and do the merge. After that, we can deal with #16. :+1:

Thanks!

patocallaghan commented 11 years ago

Thanks for having a look at this @mhulse

mhulse commented 11 years ago

Awesome! Thanks Pat. :+1: