search

JoshBrudnak / Lojidoc

A tool for generating markdown documentation for java projects
https://joshbrudnak.github.io/Lojidoc
Apache License 2.0
7 stars 7 forks source link

Add windows support #9

Closed JoshBrudnak closed 5 years ago

JoshBrudnak commented 5 years ago

Currently lojidoc does not work on Windows due to a number of unknown bugs. We need to test it on windows and figure out where it is failing.

Treevs commented 5 years ago

Relating to the problem that cropped up in issue #5, I think it's struggling on the carriage return token. I added it to the lex_contents function next to ' ' and '\t' and it works for me on Windows 10.

It's an incredibly small fix, but the output looks the same on Windows 10 and OSX for the couple Java files I tested it on and I didn't see any other Windows related issues. I have a pull request ready to go if you'd like, unless there are other Windows bugs you'd like looked into.

JoshBrudnak commented 5 years ago

I'm not sure if that fixes all the issues on Windows but I'm definitely willing to merge in your changes. Thanks. :tada:

JoshBrudnak commented 5 years ago

Successfully tested on Windows, closing