Fix issue with `String#contains`

[octosteve]

Atom seems to like String#includes over String#contains all of a sudden on my install. If you can verify this is a problem for others, here's the change. Closes #13

[JoshCheek]

The fix

Yeah, I just updated from 0.186.0 to 0.189.0 and experienced this.

Given that this would break 0.186.0, do you think its reasonable to do this? Which I assume will work on both:

(capturedError.contains || capturedError.includes)('LoadError')

Or, alternatively, there is apparently a "polyfill" (taken from the MDN docs)

if (!String.prototype.includes) {
  String.prototype.includes = function() {'use strict';
    return String.prototype.indexOf.apply(this, arguments) !== -1;
  };
}

Actually, what about using indexOf directly?

capturedError.indexOf('LoadError') !== -1

Investigation

• Don't see any discussion / explanation on their forum
• Their docs don't seem to cover the language itself
• Looking through their source, I found "String.contains is not a standard method in Chrome 41" 2620c95d86dc98aae2f5730a193f23c7ff46f803
• And looking at v8 source, found a "discussion" about this at which didn't give me any useful context. The relevant commits, though:
  • They rename it for some reason 2dae17f
  • They revert it b3acdf5
  • They recommit it 5aed61c

What the fuck, Javascript?

I find JavaScript to be completely opaque :(

My copy of node has neither (modified for readability):

$ node --version
v0.10.26

$ node -pe '"abc".includes("b")'
TypeError: Object abc has no method 'includes'
"abc".includes("b")
      ^

$ node -pe '"abc".contains("b")'
TypeError: Object abc has no method 'contains'
"abc".contains("b")
      ^

MDN docs say it should be includes, but that it's an "experimental technology, part of the ECMAScript 6 (Harmony) proposal".

And I can't figure out how to get a list of methods for strings, yet somehow Chrome and Node can provide an autocomplete list:

It makes no sense to me. I'll switch it to includes, but I have no confidence it won't just magically break again at some point. I swear this language is fkn capricious.

[JoshCheek]

• And how does this not break the web? Is the dev console able to use methods that normal JS can't? Won't there be tons of code that hits this issue suddenly?
• And am I modifying all JS across Atom by adding the polyfill? Implies I should go with the first solution, then, or switch it to use indexOf, which I assume will continue to be supported.
• Why does the polyfill go so far out of its way to get to the function? Why don't they define it like this?

[JoshCheek]

I'm going to merge this and switch it to indexOf so that I don't break anyone on an older version. Happy to hear any input you have, Steve. And thanks for the fix ^_^ I didn't even know it was broken >.<

You going to DCamp this year? https://twitter.com/ruby_dcamp/status/582963878327353344 Would love to see y'all again! (edit: Oh, nvm, you are :P)

[octosteve]

I think indexOf is the way to go. Don't get me started on JS...

[octosteve]

@JoshCheek See you there!