search

JoshCheek / atom-seeing-is-believing

Seeing is Believing integration for the Atom text editor.
Do What The F*ck You Want To Public License
62 stars 4 forks source link

TextEditor.setScrollTop is deprecated. #29

Closed youssef-sobhy closed 7 years ago

youssef-sobhy commented 7 years ago

This is now a view method. Call TextEditorElement::setScrollTop instead.

TextEditor.setScrollTop (/usr/share/atom/resources/app.asar/src/text-editor.js:3494:12)
Object.withoutMovingScreenOrCursor (/home/joe/.atom/packages/seeing-is-believing/lib/seeing-is-believing.coffee:111:21)
<unknown> (/home/joe/.atom/packages/seeing-is-believing/lib/seeing-is-believing.coffee:66:26)
ChildProcess.<anonymous> (/home/joe/.atom/packages/seeing-is-believing/lib/seeing-is-believing.coffee:95:16)
emitTwo (events.js:106:13)
ChildProcess.emit (events.js:191:7)
JoshCheek commented 7 years ago

Ty, going to look at it now. Closing the issue as a duplicate of #28

JoshCheek commented 7 years ago

Should be fixed and released, ty for reporting!

youssef-sobhy commented 7 years ago

Oh, didn't see the other report, I apologize and thanks for fixing the issue.