search

JoshCheek / seeing_is_believing

Displays the results of every line of code in your file
1.3k stars 54 forks source link

[BUGFIX] allows forks; closes #85 #105

Closed jkantarek closed 7 years ago

jkantarek commented 7 years ago

adds exceptions and allows forking pairing with @JoshCheek

JoshCheek commented 7 years ago

Thanks, Jeff, good pairing with you today :)

The CI failures weren't from this, they were from some code I wrote on the train w/o internet to push to CI at the time. Ultimately, they expected a dir to exist, passed locally b/c prev runs had made the dir, failed on CI b/c git doesn't track empty dirs.

I also wound up having to sort the errors because the forking is not deterministic, so either one could happen first.

JoshCheek commented 7 years ago

Wow, I was tired when I looked at this, lol. I just realized that we actually saw the CI failure locally. If you recall the first time we ran the tests they failed and the second time they passed. I said something like "that's alarming". Anyway, it's fixed now.