search

JoshCheek / seeing_is_believing

Displays the results of every line of code in your file
1.31k stars 54 forks source link

Doesn't run on Ruby 2.2.x #27

Closed JoshCheek closed 9 years ago

JoshCheek commented 10 years ago

Issue1 (fixed)

Syntax error in binary.rb. This is easy enough to fix with a few parens.

ruby -c lib/seeing_is_believing/binary.rb
lib/seeing_is_believing/binary.rb:189: syntax error, unexpected modifier_if
        exception:   if results.has_exception?
                       ^
lib/seeing_is_believing/binary.rb:195: syntax error, unexpected ',', expecting keyword_end
lib/seeing_is_believing/binary.rb:198: syntax error, unexpected modifier_if
...                  exception: if result.has_exception?
...                               ^
lib/seeing_is_believing/binary.rb:203: syntax error, unexpected keyword_end, expecting '}'
lib/seeing_is_believing/binary.rb:219: syntax error, unexpected keyword_end, expecting '}'

Issue2

Parser doesn't yet (as of version 2.1.9) support Ruby 2.2.x

JoshCheek commented 10 years ago

Syntax fix from 48c265cb56d9d227948bcf37efd1a2eb4cb372b2 verified with this fish script.

$ for f in (find . | grep -i rb | grep -v proving); ruby -c $f; end
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
Syntax OK
JoshCheek commented 9 years ago

New parser is out with 2.2 support, SiB 2.2.0 and 3.0.0.beta4 depend on it, so this is fixed. Also, v3.0 is tested against 2.2.0 on CI.