JoshClose / CsvHelper

Library to help reading and writing CSV files
http://joshclose.github.io/CsvHelper/
Other
4.73k stars 1.06k forks source link

Request for Support for GB2312 Encoding in Your Library #2272

Open qq786838943 opened 3 months ago

qq786838943 commented 3 months ago

I am a dedicated user of your library and appreciate the excellent tools you provide. However, I have encountered a challenge while working with GB2312 encoded text files. GB2312 remains a common character encoding in China, particularly for maintaining and converting data from legacy systems.

I've noticed that your library currently does not support GB2312 encoding, which prevents me from using your tools directly for handling such files. Therefore, I kindly request your team to consider adding support for GB2312 encoding in future versions of the library.

I would be happy to provide further details about the practical use cases and benefits of supporting GB2312 encoding. I believe this enhancement would not only resolve my current issue but also benefit many other developers who rely on GB2312 encoding.

Looking forward to your response. Thank you for your attention to this matter.

Best regards,

JoshClose commented 3 months ago

What issues are you having? CsvHelper knows nothing about the encoding you're using. You pass in a TextReader which is where encoding is handled. If you're using a StreamReader, you would set the encoding there.