search

JoshDSommer / nativescript-ngx-shadow

Angular directive to apply shadows to native elements according to the elevation level guidelines of material design specification
Apache License 2.0
9 stars 6 forks source link

Rebase on nativescript-plugin-seed #23

Open jnorkus opened 4 years ago

edusperoni commented 4 years ago

Hey @jnorkus ! Thanks for the contribution, but since this repo is angular only, it doesn't follow the plugin seed format, but the Angular Package Format with ng-packagr, so I'm not sure this will be merged :(

jnorkus commented 4 years ago

That's a good point @edusperoni. I wasn't aware of this specification. Are there any benefits of keeping it on a different format in the context of NativeScript? I did it mainly because I couldn't get it to build so decided it would be easier to just rebase on the plugin seed. And it works fine for me now.