JoshDSommer / nativescript-ngx-shadow

Angular directive to apply shadows to native elements according to the elevation level guidelines of material design specification
Apache License 2.0
9 stars 6 forks source link

increase ListView compatibility #9

Closed edusperoni closed 5 years ago

edusperoni commented 5 years ago

Fixes #6

edusperoni commented 5 years ago

I think this is pretty minor, provably just a patch. Perfomance gain should be very small (since loaded/unloaded will usually run outside angular's zone and won't trigger cd), the main thing this fixes is we don't have to put some *ngIfs around to make sure it doesn't break the listviews

JoshDSommer commented 5 years ago

Sounds good, thanks again @edusperoni

JoshDSommer commented 5 years ago

Published in 6.4.0