search

JoshDSommer / nativescript-slides

A NativeScript plugin that is for Intro Tutorials, Image Carousels or any other slide functionality
Other
70 stars 32 forks source link

Please handle this case #109

Closed shiv19 closed 7 years ago

shiv19 commented 7 years ago

When I run my app with nativescript-slides on android I get this in the logs

JS: clipToBounds with value false is not supported on Android. You can use this.android.getParent().setClipChildren(false) as an altern
ative

Can you handle this please by adding a check on line 502 of nativescript-slides.ts

if(app.android){
    this.android.getParent().setClipChildren(false);
}
if(app.ios){
    footerInnerWrap.clipToBounds = false;
}
JoshDSommer commented 7 years ago

Thank you for the heads up @shiv19 I'll look into this here

JoshDSommer commented 7 years ago

resolved in 2.2.12

shiv19 commented 7 years ago

Thanks Josh 👍