JoshDSommer / nativescript-slides

A NativeScript plugin that is for Intro Tutorials, Image Carousels or any other slide functionality
Other
70 stars 32 forks source link

Can't disable loop property #111

Open Macarthurval opened 6 years ago

Macarthurval commented 6 years ago

Hello, I'm testing the demo app and I can see that the loop property on the container element has no effect, looping alike from the last slide to the first one and backwards even when this property is disabled.

<Slides:SlideContainer id="slides" row="0" pageIndicators="true" loop="false" start="onStart" cancelled="onCancelled" changed="onChanged" finished="onFinished">

I've tried too changing this property in the code, with no success:

sliderContainer = page.getViewById('slides') sliderContainer.loop = false

I think this feature is essential and I would like to get support with it please. My tns version is 3.1.3.

And thanks for this great plugin. Regards.

cjb5790 commented 6 years ago

+1

This appears to work when the property is provided without any value. i.e. loop=""

However, if any value is provided, the expression is evaluated as true.