search

JoshDSommer / nativescript-slides

A NativeScript plugin that is for Intro Tutorials, Image Carousels or any other slide functionality
Other
70 stars 32 forks source link

Added the interval feature #3

Closed Obsessive closed 8 years ago

Obsessive commented 8 years ago

Now the slides will change on regular interval.

Obsessive commented 8 years ago

Hi, can you add that this plugin is also a carousel in the nativescript rocks plugin description because now it also has a feature of slideshow.

JoshDSommer commented 8 years ago

@Obsessive this looks great! I'll test it with it this evening, in the meantime feel free to add your self as a contributor to the package.json file. n Thanks again!

Obsessive commented 8 years ago

Thanks man

JoshDSommer commented 8 years ago

@Obsessive What are you thoughts about renaming the plugin to just slides. I feel like it will continue expanding past the original use case, and rather do it now since as intro slides it's pretty stable.

Obsessive commented 8 years ago

When i started working on nativescript i needed a carousel view for the app just like bootstrap carousel which is available for websites then i found your plugin and used setinterval function to mimic it. So, I think nativescript-carousel would be a good name and nativescript-slides is also a good name because it is more than a image carousel. We can add any element into it like buttons, dropdowns, switches, segmentedbars, lists and so on.And finally it is your call. Thanks for asking my opinion man.

JoshDSommer commented 8 years ago

@Obsessive when you have a chance could you pull down the latest version, I've changed the project name and it's created a merge conflict. Sorry :(

Obsessive commented 8 years ago

Ok

Obsessive commented 8 years ago

Can you take a glance at the code to avoid any copy paste mistake i might have made.

JoshDSommer commented 8 years ago

Thanks for taking a look at it, but It looks like in the merge reverted some of the name changes,

https://github.com/TheOriginalJosh/nativescript-slides/pull/3/files#diff-04c6e90faac2675aa89e2176d2eec7d8L9

For example, the class was changed from IntroSlides to SlideContainer. I know this is a pain.

Obsessive commented 8 years ago

Ok i will change them and send the new files.

JoshDSommer commented 8 years ago

@Obsessive Thank you I appreciate it. :)

JoshDSommer commented 8 years ago

Github is still complaining about a merge conflict. If it's still I problem I'll take a look tonight.

Obsessive commented 8 years ago

can you post the link to view the conflicts

JoshDSommer commented 8 years ago

@Obsessive It looks like we are good now! I'm going to merge it and tonight I'll publish. Thanks again man!

Obsessive commented 8 years ago

Ok