search

JoshData / fast_diff_match_patch

Python package for Google's diff-match-patch native C++ implementation.
https://pypi.org/project/fast-diff-match-patch/
Apache License 2.0
73 stars 27 forks source link

Add an interface to the match_main method in diff-match-patch. #8

Closed freakboy3742 closed 6 years ago

freakboy3742 commented 6 years ago

The tests on this patch depend on #7.

freakboy3742 commented 6 years ago

@JoshData Well sure - but the alternative is an exception that isn't helpful when it is raised.

Well..., there's one other option - drop support for Python 2.7 and 3.4. Python 3.5 has Py_EncodeLocale available natively, which is all that is really needed.

JoshData commented 6 years ago

I'm fine dropping support for nice error messages in 2.7 and 3.4. :) Can just replace the body of the function with return "unspecified error" :).

JoshData commented 6 years ago

Thanks!