search

JoshKaufman / ursa

URSA - RSA public/private key OpenSSL bindings for Node.js
Other
619 stars 135 forks source link

Do you mind if I update the tests to mocha? #108

Closed mansona closed 7 years ago

mansona commented 8 years ago

Hey Folks,

I was going to spend some time updating the testing system for this repo to mocha but I thought I should ask first ;)

I was looking at the travis output for this PR https://github.com/quartzjer/ursa/pull/107 and I noticed that it didn't show a list of the tests that passed, instead it just says "All tests pass!" in the Travis output. If you have a look at one of my other modules and compare the Travis output https://travis-ci.org/Blooie/express-autoroute/jobs/74972233

Like i said, I would love to update the tests but I didn't want to just land a PR without asking first :wink:

quartzjer commented 8 years ago

I would definitely love that, I doubt anyone would complain about having better test output :)

:+1:

On Oct 2, 2015, at 6:52 AM, Chris Manson notifications@github.com wrote:

Hey Folks,

I was going to spend some time updating the testing system for this repo to mocha but I thought I should ask first ;)

I was looking at the travis output for this PR #107 and I noticed that it didn't show a list of the tests that passed, instead it just says "All tests pass!" in the Travis output. If you have a look at one of my other modules and compare the Travis output.

Like i said, I would love to update the tests but I didn't want to just land a PR without asking first

— Reply to this email directly or view it on GitHub.

mansona commented 8 years ago

:joy: great, i'll take a look this week some time. :+1: