search

JoshKaufman / ursa

URSA - RSA public/private key OpenSSL bindings for Node.js
Other
619 stars 135 forks source link

Simplify binding.gyp #149

Open davedoesdev opened 7 years ago

davedoesdev commented 7 years ago

On Windows, Node 6.3.0 exports the OpenSSL symbols which means we don't have to look for them. It also means we don't have hassle when OpenSSL change their library names as happened in 1.1.0.

Note if this change goes in then on Windows ursa would require Node 6.3.0 or above. I'm not sure whether this would be an acceptable price to pay for more reliable Windows support going forward.

quartzjer commented 7 years ago

I'm looking for a new maintainer: https://github.com/quartzjer/ursa#maintainer-needed

davedoesdev commented 7 years ago

I guess the first question is what are the alternatives if ursa went away? i.e. is there some other module which is viable for ursa's use cases?

bpringe commented 7 years ago

I have had no success install ursa on Node 6.10.0 or 7.6.0 on Windows 10. When you said 6.3.0 did you mean that version or earlier?

JoshKaufman commented 7 years ago

@davedoesdev it's been awhile since you worked on this, how do you feel about it?

  1. does this actually fix any issues or is it just cleaning up the binding.gyp.
  2. I think it makes sense to to require 6.3.0+ but it will have to be a major release.
davedoesdev commented 7 years ago

I've moved away from ursa now. Core Node crypto does almost all I need now (PSS, OAEP). The only thing missing was fast keygen, which I wrote myself using N-API.