search

JoshKaufman / ursa

URSA - RSA public/private key OpenSSL bindings for Node.js
Other
619 stars 135 forks source link

update(): update to NodeJS 10 or OpenSSL 1.1.0 (closes #167) #169

Closed jkuri closed 6 years ago

jkuri commented 6 years ago

I made it backward compatible with previous NodeJS/OpenSSL versions.

lognaturel commented 6 years ago

Confirmed working well on macOS 10.13.4, node v10.2.1. Thanks, @jkuri!

@JoshKaufman What can users do to help get this ready for merge?

deluxor commented 6 years ago

Working perfectly on Linux, with latest Node 10.2.1 and NPM 6.1.0 Good job!

> ursa@0.9.4 install /home/deluxor/home/Loqr/lcp-node-sdk/node_modules/ursa
> node-gyp rebuild

make: Entering directory '/home/deluxor/home/Loqr/lcp-node-sdk/node_modules/ursa/build'
  CXX(target) Release/obj.target/ursaNative/src/ursaNative.o
  SOLINK_MODULE(target) Release/obj.target/ursaNative.node
  COPY Release/ursaNative.node
make: Leaving directory '/home/deluxor/home/Loqr/lcp-node-sdk/node_modules/ursa/build'
updated 3 packages and audited 111 packages in 9.455s
LoganDark commented 6 years ago

It works, so merge it please, production code won't run because I can't build this on a Compute Engine instance.

LoganDark commented 6 years ago

Thank you!

jkuri commented 6 years ago

@JoshKaufman thanks for merging, can you also publish a new version to npm please?

mtgto commented 6 years ago

I'm also waiting for publishing 😂😂😂

bmunkholm commented 6 years ago

Please @JoshKaufman can publish? Or alternatively, give others rights to do so? It's highly preferred from forking and maintaining that.

delfuego commented 5 years ago

Will this ever make it to npm? It's much harder to do CI builds without there being a dependable npm source for this fix.

JonasRech commented 5 years ago

@quartzjer as the new maintainer, could you please do a publish to NPM? It can't be so hard...