Open rzr opened 5 years ago
I’m a little confused as to what this does. At a glance it looks like it removes linking to libssl and libcrypto, which seems like it couldn’t possibly help.
What is the message that this is intended to fix?
How does this fix it?
Oops! Reverse that. I see that this ADDS linking.
That said, I’d still like to understand better the problem and what this is doing to fix it.
Please @jkuri explain how this fixed the node10 support ?
NodeJS 10 uses newer version of integrated OpenSSL than previous Node versions do. Because I reformatted existing source code its it is hard to find updates related to OpenSSL version upgrade, but if you check closely you can find them :-).
/cc @rzr @coolaj86
@jkuri it happened only with electron and node 10 on ubuntu 18
Is there anything preventing to merge this ? or are we lacking maintainers ?
I guess the maintainer is too busy
Yes it looks like @JoshKaufman has other priorities that's why I am suggesting to move project to co-maintenance model
https://github.com/JoshKaufman/ursa/issues/172
Is anyone willing to help on this ?
Author: knobik knobiks@gmail.com Change-Id: If48e0ae4d0ace41052f50accf503a287f2dcb4e4 Origin: https://github.com/jkuri/ursa/commit/02fd45862fa6f99705b35fd1b66865bf22588c13 Bug: https://github.com/JoshKaufman/ursa/issues/175 Signed-off-by: Philippe Coval p.coval@samsung.com