JoshLmao / Genify

🎵 Lyrics for your current Spotify song, online and available at the click of a button
https://genify.joshlmao.com
MIT License
16 stars 2 forks source link

Hello there)) #14

Open FiftyFour7250 opened 3 years ago

FiftyFour7250 commented 3 years ago

Heeeeeey. I'm the guy who asked you to improve site last summer. Just saw that you were back to work, and I noticed that my bug reports hidden and marked as spam (probably because that account was registered to a temp mail :D). I guess they're not available to you too. So if you need examples of the of structure of song titles that don't have lyrics, or have wrong lyrics - let me know. (Yea, still hope you fix it). I also shared about your app yesterday, think now a little more people will start using it, hope this will give you motivation)))

2324234 2222

JoshLmao commented 3 years ago

Hey! Yes, I noticed this a while ago too and I couldn't remember what they said. If you still know what those issues are, I'd appreciate it if you could remake them (just the To Do one).

And thanks for sharing! I will work on this again soon, just in the middle of Uni work, haha

FiftyFour7250 commented 3 years ago

Ok. I'm not programmer, and I don't know how it works at all, but it seems to me that it's worth giving up the search in Genius, and use Google search, or another search engine. Because ALWAYS, on the query "site:genius.com SongName ArtistName" - FIRST RESULT was correct.

(Click on images to enlarge)

"-" issue. It looks like all the songs that contain " - " in the title can't find lyrics.

1 4 3 5 9

"(with...)" issue. It looks like all the songs that contain " (with...) " in the title can't find lyrics.

21 22 23 24 25

Two languages issue. If the title uses Russian and in parentheses English - app can't find lyrics. If English without brackets, then everything is fine.

31 51 52 53 54

Artist Name issue. If the artist's names different in Spotify and Genius - app can't find lyrics. Google is still doing great.

No "WWE" in the artists on Genius. 32

This guy has two nicknames, but on Genius all his songs under one name. 41

Probably "x" and "&" 42

Interesting, this is unreleased track that I have in local files, and the name of which I came up with myself - Google still finds it. 43

JoshLmao commented 3 years ago

Thanks for the research. I mean, this primarily comes down to Google's algorithm showing why it's the best. Unfortunately, from a programmers point of view, using Google's API's would limit the sites capabilities immensely. I used it previously for the YouTube video feature but I would quickly hit the API rate limit just by myself.

I know my algorithm to perform the best search on Genius isn't amazing, but I just need to work towards improving it. I'd also like to avoid adding more than necessary API calls to different services

FiftyFour7250 commented 3 years ago

Well then I hope you can fix it) Added another issue. If I come across something else - I'll also add it there. Good luck))

FiftyFour7250 commented 3 years ago

Wow! You fixed it. Though you wrote that search improved only for remixes, I checked the songs above, checked others, and now everything works perfectly. All lyrics correctly. Thanks)

JoshLmao commented 3 years ago

Yeah, glad you noticed! There's still some other scenarios I need to fix, such as songs with "Live" in or "feat.." so I'll leave the issue open but I got "Remix" working. Thanks for your example pics too, I used the songs in them to test 😉

FiftyFour7250 commented 3 years ago

I found something else. It looks like something with a dot. I don't know if it's worth fixing, especially if it might mess up the algorithm you have now. After all, these cases are not enough. Just letting you know)

Rihanna, Eminem -- Love The Way You Lie (Part II) - Pt. 2 (lyrics from another song) https://open.spotify.com/track/6M6lsQB4OhqL41eld29PeC?si=L8CbzpH1TQG5gZ9_27fBBQ

Kendrick Lamar, Zacari -- LOVE. FEAT. ZACARI. https://open.spotify.com/track/6PGoSes0D9eUDeeAafB2As?si=DUNZwVmaQU-42tySqHQdzQ

Баста, Скриптонит -- Рай.он (lyrics from another song) https://open.spotify.com/track/0XEjmpySsQRF2b3cfPAuPP?si=Cq47_4yITxaQ1CnJ_30LNA

Kid Cudi -- Solo Dolo, Pt. III https://open.spotify.com/track/27oVCAziETRbNuo5A8LNpg?si=7NpZdb07SKeadHIrrm5VUg

JoshLmao commented 3 years ago

Any case where Genify doesn't work, I want to attempt to fix and get working so any examples you have, let me know! I appreciate it :D I'll get around to them all eventually, haha

FiftyFour7250 commented 3 years ago

N-word problem. Even here :D

DMX -- My Ni**as - Soundtrack Version (R.I.P.) https://open.spotify.com/track/1lJpJnrv0m25urQix0oYx3?si=5fB1HniqSRGQDzz23c0snQ

NAS -- N.I.*.*.E.R. (The Slave and the Master) https://open.spotify.com/track/58crvUIMh7VjARw1HAhsU3?si=18gioe03Rhy79xBT33pwsg

Meek Mill, YG, Snoop Dogg -- That's My N**** (with Meek Mill, YG & Snoop Dogg) (lyrics from another song) https://open.spotify.com/track/3i1B1PnsfnOQPGVIzhf1lr?si=j2cmSmJrTtO17Xi5rfTHRg

JAY-Z, Kanye West -- Ni**as In Paris https://open.spotify.com/track/4Li2WHPkuyCdtmokzW2007?si=6EVSlRqASsmLQlxL_R8QzQ

Lil Wayne -- That's What Ni**as Do https://open.spotify.com/track/7nrdN0MyGIbsWbfowJpyJW?si=y6Wen0r2S6yqhRmW_BfT7g

But these two work ¯\_(ツ)_/¯

NAS -- Y'all My Ni**as https://open.spotify.com/track/0w5OlAK2fO54k9b2t2IPfH?si=GfNxikfuTciXE2Oo0ZS7BA

F**kin' Problems (feat. Drake, 2 Chainz & Kendrick Lamar) https://open.spotify.com/track/4X5f3vT8MRuXF68pfjNte5?si=tvJZiFKNSpSKAAyrhmaxGA