search

JoshMarler / react-juce

Write cross-platform native apps with React.js and JUCE
https://docs.react-juce.dev
MIT License
764 stars 79 forks source link

(#34) Rename top-level namespace to reactjuce:: #216

Closed nick-thompson closed 3 years ago

nick-thompson commented 3 years ago

w00t!

After this, most of what's left is updating references to "Blueprint" in the documentation and internal names for coordinating js<>C++ access (e.g. BlueprintBackend)

nick-thompson commented 3 years ago

Just tacked on a second commit to cover what I think is the rest of the real renaming effort. Probably best to look at this commit by commit now.

After this, all that's left is really:

Before merging this I'll bump react-juce to 0.2.10 on npm and update the package jsons

JoshMarler commented 3 years ago

@nick-thompson, Nice! Looking solid. Pulled down on linux machine and all looking good.

Ran a grep under react-juce/core directory and still a few "blueprint" references. Are we leaving for the moment? Things like:

#ifdef BLUEPRINT_H_INCLUDED

funcId(juce::String("blueprintCallback")

Also index.js in GainPlugin example.

I'm not sure if these are outside the planned scope of this PR?

nick-thompson commented 3 years ago

Ok, covered another few and bumped 0.2.10 on npm.

#ifdef BLUEPRINT_H_INCLUDED I will come back for in a later PR while also addressing the test runner.