Closed utokusa closed 3 years ago
Awesome work @utokusa thank you. I've looked briefly and the approach generally looks totally right. I want to review in closer detail before merge, will try to get to it in the morning!
Excellent work @utokusa. This looks pretty much ready to merge now. We'll need to publish a new version of the react-juce
npm package for this and bump the example project etc. Very happy to pull down your branch to test and push the package changes etc.
@nick-thompson did you want to take a quick pass over this before merge?
@utokusa looks like we have a merge conflict here, would you mind rebasing your branch against the latest master, fixing the conflict, and then force pushing? And then I'll go ahead and merge!
@nick-thompson I have just rebased and force pushed. Now the commit log is bit strange and my non-latest commits fails to build because of the namespace change. So I think it might be better to squash them. What do you think? Either way, it would be helpful if you could check for the latest commit.
I noticed that the GitHub Action was failed. Please wait and I will fix it.
I have just fixed it. The CI really helped me :)
Excellent, thanks again @utokusa! 😃 🚀
This PR is related to #21 .
Summary
This PR allows you to use
TextInput
component which has similar behavior of<input type="text">
.Features
value
prop is provided)OnInput
andOnChange
callbackfontSize
,placeholder
,maxlength
, etc.juce::TextEditor
's properties. e.g. 'highlight-color' which can be set byjuce::Component::setColour()
in original JUCE