JoshMarler / react-juce

Write cross-platform native apps with React.js and JUCE
https://docs.react-juce.dev
MIT License
764 stars 79 forks source link

Add TextInput component #217

Closed utokusa closed 3 years ago

utokusa commented 3 years ago

This PR is related to #21 .

Summary

This PR allows you to use TextInput component which has similar behavior of <input type="text">.

screenshot

Features

nick-thompson commented 3 years ago

Awesome work @utokusa thank you. I've looked briefly and the approach generally looks totally right. I want to review in closer detail before merge, will try to get to it in the morning!

JoshMarler commented 3 years ago

Excellent work @utokusa. This looks pretty much ready to merge now. We'll need to publish a new version of the react-juce npm package for this and bump the example project etc. Very happy to pull down your branch to test and push the package changes etc.

@nick-thompson did you want to take a quick pass over this before merge?

nick-thompson commented 3 years ago

@utokusa looks like we have a merge conflict here, would you mind rebasing your branch against the latest master, fixing the conflict, and then force pushing? And then I'll go ahead and merge!

utokusa commented 3 years ago

@nick-thompson I have just rebased and force pushed. Now the commit log is bit strange and my non-latest commits fails to build because of the namespace change. So I think it might be better to squash them. What do you think? Either way, it would be helpful if you could check for the latest commit.

utokusa commented 3 years ago

I noticed that the GitHub Action was failed. Please wait and I will fix it.

utokusa commented 3 years ago

I have just fixed it. The CI really helped me :)

nick-thompson commented 3 years ago

Excellent, thanks again @utokusa! 😃 🚀