Implement dispatch event to pass gain level values to Meter component

JoshMarler / react-juce

Write cross-platform native apps with React.js and JUCE

https://docs.react-juce.dev

MIT License

764 stars 79 forks source link

Closed ilionic closed 3 years ago

ilionic commented 3 years ago

Fixes Meter in GainPlugin example.

Read gainPeakValue in processBlock.
Initialise 100ms (arbitrary number) Timer to call dispatchEvent passing gain values to Meter component
Add public getReactAppRoot getter to GenericEditor in order to call dispatchEvent from appRoot instance created by it as suggested by Nick.

JoshMarler commented 3 years ago

@nick-thompson , happy for this to be merged now?

nick-thompson commented 3 years ago

Yep this is excellent! Thanks very much @ilionic 🙏 , I'm going to squash these commits into one on the way in

ilionic commented 3 years ago

Noticed build failed due to Juce 6 namespacing left overs, sorry about that :)

nick-thompson commented 3 years ago

No worries! I'm surprised I didn't notice it before hitting the merge button 🤷‍♂️ . Anyways, all is good now

ilionic commented 3 years ago

Actually might be good idea to run checks on PR's as well, not only upon master merge?

nick-thompson commented 3 years ago

Definitely!