search

JoshMarler / react-juce

Write cross-platform native apps with React.js and JUCE
https://docs.react-juce.dev
MIT License
764 stars 79 forks source link

ShadowView Pimpl pattern. #242

Closed JoshMarler closed 3 years ago

JoshMarler commented 3 years ago 
There's a few nasty things to sort out here.

@nick-thompson , Opening this up slightly ahead of time as might be a few discussion points here. Couple elements of controversy!

JoshMarler commented 3 years ago

@nick-thompson , think this is ready for a final pass after our Discord discussions. I think there's probably some opportunity to refactor around TextShadowView even more to remove some ugliness but not immediately apparent. It think this might be "OK for now" but require revisiting at some point.

As discussed I've hit a need for this due to facebook namespace clash with folly function due to YGLayout.h having a using namespace facebook::yoga