search

JoshMarler / react-juce

Write cross-platform native apps with React.js and JUCE
https://docs.react-juce.dev
MIT License
763 stars 79 forks source link

Topic/stylesheet api #272

Closed JoshMarler closed 2 years ago

JoshMarler commented 3 years ago

@nick-thompson , Opening this up as I go along so we can use it as discussion vehicle rather than me spamming you to death on Discord.

I'll pop a few comments inline with questions. Overall everything is working but obviously this needs a bit of tidying.

We'll get an A/B timing diff pre/post StyleSheet for initial app render to see how big a win this is. Suspect it will be pretty significant.

Perhaps we also shove a print in performRootShadowTreeLayout and friends to see how much this reduces calls to that hot spot.

JoshMarler commented 3 years ago

@nick-thompson , Will fix linter checks before this goes in. Think I've got vim at 4 space tabs etc. Will trying running linter or edit.